Common static analysis issue remediation

In this guide we'll look at using OpenRewrite to perform an automated remediation for many issues identified by common static analysis tools.
Example Configuration
The Common Static Analysis Recipe consists of more than 50 types of issues and can be applied by including OpenRewrite's plug-in to your project and configuring the recipe:
Maven
Gradle
pom.xml
<plugin>
  <groupId>org.openrewrite.maven</groupId>
  <artifactId>rewrite-maven-plugin</artifactId>
  <version>4.46.0</version>
  <configuration>
    <activeRecipes>
      <recipe>org.openrewrite.java.cleanup.CommonStaticAnalysis</recipe>
    </activeRecipes>
  </configuration>
</plugin>
build.gradle
plugins {
    id("java")
    id("org.openrewrite.rewrite") version("5.40.0")
}
​
rewrite {
    activeRecipe("org.openrewrite.java.cleanup.CommonStaticAnalysis")
}
​
repositories {
    mavenCentral() // rewrite is published to Maven Central
}
At this point, you're ready to fix common static analysis issues by running mvn rewrite:run or gradlew rewriteRun.
Before and After
For the full list of changes this recipe will make, see its reference page.
Use explicit types on lambda arguments
Before
After
queue.findAll().forEach(msg -> {
    WebSocketMessageBody toSend = conv.fromMap(msg.getMessage(), WebSocketMessageBody.class);
    session.sendSync(toSend);
});  
queue.findAll().forEach((MessageQueue msg) -> {
    WebSocketMessageBody toSend = conv.fromMap(msg.getMessage(), WebSocketMessageBody.class);
    session.sendSync(toSend);
});   
No Double Brace Initialization
Before
After
class Menu {
    static final List<String> menuItems = Arrays.asList("rice", "beans");
    
    void newOrder(String main, String desert) {
        List<String> menuItems = new ArrayList<>() {
            {
                add(main);
                add(desert);
            }
        };
        ...
    }
}
class Menu {
    static final List<String> menuItems;
    static {
        menuItems = new ArrayList<>();
        menuItems.add("rice");
        menuItems.add("beans");
    }
    
    void newOrder(String main, String desert) {
        List<String> menuItems = new ArrayList<>();
        menuItems.add(main);
        menuItems.add(desert);
        ...
    }
}
Fields in a Serializable class should either be transient or serializable
Before
After
public class MessageExtBatch implements Serializable {
    private ByteBuffer encodedBuff;
    ...
}
public class MessageExtBatch implements Serializable {
    private transient ByteBuffer encodedBuff;
    ...
}
Known Limitations
We don't have OpenRewrite recipes implemented for all publicly available policies. If you find a violation you'd like automated, visit the rewrite repository and file an issue.

Popular recipe guides

Automatically fix Checkstyle violations

Last modified 7d ago