Common static analysis issues

org.openrewrite.java.cleanup.CommonStaticAnalysis Resolve common static analysis issues discovered through 3rd party tools.
Source
​Github, Issue Tracker, Maven Central​
groupId: org.openrewrite
artifactId: rewrite-java
version: 7.38.0
Usage
This recipe has no required configuration parameters and comes from a rewrite core library. It can be activated directly without adding any dependencies.
Gradle
Maven POM
Maven Command Line
build.gradle
plugins {
    id("org.openrewrite.rewrite") version("5.38.0")
}
​
rewrite {
    activeRecipe("org.openrewrite.java.cleanup.CommonStaticAnalysis")
}
​
repositories {
    mavenCentral()
}
​
pom.xml
<project>
  <build>
    <plugins>
      <plugin>
        <groupId>org.openrewrite.maven</groupId>
        <artifactId>rewrite-maven-plugin</artifactId>
        <version>4.42.0</version>
        <configuration>
          <activeRecipes>
            <recipe>org.openrewrite.java.cleanup.CommonStaticAnalysis</recipe>
          </activeRecipes>
        </configuration>
      </plugin>
    </plugins>
  </build>
</project>
You will need to have Maven installed on your machine before you can run the following command.
shell
mvn -U org.openrewrite.maven:rewrite-maven-plugin:run \
  -Drewrite.activeRecipes=org.openrewrite.java.cleanup.CommonStaticAnalysis
Definition
Recipe List
Yaml Recipe List
​Add serialVersionUID to a Serializable class when missing​
​Atomic Boolean, Integer, and Long equality checks compare their values​
​BigDecimal rounding constants to RoundingMode enums​
​Boolean checks should not be inverted​
​CaseInsensitive comparisons do not alter case​
​Catch clause should do more than just rethrow​
​Chain StringBuilder.append() calls​
​Covariant equals​
​Default comes last​
​Remove empty blocks​
​Equals avoids null​
​Explicit initialization​
​Externalizable classes have no-arguments constructor​
​Finalize private fields​
​Fall through​
​Finalize classes with private constructors​
​Fix String#format and String#formatted expressions​
​for loop counters incremented in update​
​Use indexOf(String, int)​
​indexOf() replaceable by contains()​
​indexOf should not compare greater than zero​
​Inline variable​
​Use Collection#isEmpty() instead of comparing size()​
​Simplify lambda blocks to expressions​
​Rename packages to lowercase​
​Method name casing​
​switch statements should have at least 3 case clauses​
​Modifier order​
​No multiple variable declarations​
​Fix missing braces​
​Nested enums are not static​
​Change StringBuilder and StringBuffer character constructor argument to String​
​No double brace initialization​
​Use Collections#emptyList(), emptyMap(), and emptySet()​
​Use comparison rather than equality checks in for conditions​
​Remove finalize() method​
​No primitive wrappers for #toString() or #compareTo(..)​
​Jump statements should not be redundant​
​Unnecessary String#toString()​
​Unnecessary String#valueOf(..)​
​finalize() calls super​
​Use primitive wrapper valueOf method​
​Redundant file creation​
​Remove extra semicolons​
​Reformat local variable names to camelCase​
​Rename methods named hashcode, equal, or tostring​
​Reformat private field names to camelCase​
​Use method references in lambda​
​Replace StringBuilder.append() with String​
​Simplify boolean expression​
​Simplify boolean return​
​Static methods not final​
​Use String.equals() on String literals​
​Unnecessary close in try-with-resources​
​Unnecessary explicit type arguments​
​Remove unnecessary parentheses​
​Remove Nullable and CheckForNull annotations from primitives​
​Upper case literal suffixes​
​Use diamond operator​
​No C-style array declarations​
​Use lambdas where possible​
​Prefer while over for loops​
​Write octal values as decimal​
---
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.cleanup.CommonStaticAnalysis
displayName: Common static analysis issues
description: Resolve common static analysis issues discovered through 3rd party tools.
recipeList:
  - org.openrewrite.java.cleanup.AddSerialVersionUidToSerializable
  - org.openrewrite.java.cleanup.AtomicPrimitiveEqualsUsesGet
  - org.openrewrite.java.cleanup.BigDecimalRoundingConstantsToEnums
  - org.openrewrite.java.cleanup.BooleanChecksNotInverted
  - org.openrewrite.java.cleanup.CaseInsensitiveComparisonsDoNotChangeCase
  - org.openrewrite.java.cleanup.CatchClauseOnlyRethrows
  - org.openrewrite.java.cleanup.ChainStringBuilderAppendCalls
  - org.openrewrite.java.cleanup.CovariantEquals
  - org.openrewrite.java.cleanup.DefaultComesLast
  - org.openrewrite.java.cleanup.EmptyBlock
  - org.openrewrite.java.cleanup.EqualsAvoidsNull
  - org.openrewrite.java.cleanup.ExplicitInitialization
  - org.openrewrite.java.cleanup.ExternalizableHasNoArgsConstructor
  - org.openrewrite.java.cleanup.FinalizePrivateFields
  - org.openrewrite.java.cleanup.FallThrough
  - org.openrewrite.java.cleanup.FinalClass
  - org.openrewrite.java.cleanup.FixStringFormatExpressions
  - org.openrewrite.java.cleanup.ForLoopIncrementInUpdate
  - org.openrewrite.java.cleanup.IndexOfChecksShouldUseAStartPosition
  - org.openrewrite.java.cleanup.IndexOfReplaceableByContains
  - org.openrewrite.java.cleanup.IndexOfShouldNotCompareGreaterThanZero
  - org.openrewrite.java.cleanup.InlineVariable
  - org.openrewrite.java.cleanup.IsEmptyCallOnCollections
  - org.openrewrite.java.cleanup.LambdaBlockToExpression
  - org.openrewrite.java.cleanup.LowercasePackage
  - org.openrewrite.java.cleanup.MethodNameCasing:
  - org.openrewrite.java.cleanup.MinimumSwitchCases
  - org.openrewrite.java.cleanup.ModifierOrder
  - org.openrewrite.java.cleanup.MultipleVariableDeclarations
  - org.openrewrite.java.cleanup.NeedBraces
  - org.openrewrite.java.cleanup.NestedEnumsAreNotStatic
  - org.openrewrite.java.cleanup.NewStringBuilderBufferWithCharArgument
  - org.openrewrite.java.cleanup.NoDoubleBraceInitialization
  - org.openrewrite.java.cleanup.NoEmptyCollectionWithRawType
  - org.openrewrite.java.cleanup.NoEqualityInForCondition
  - org.openrewrite.java.cleanup.NoFinalizer
  - org.openrewrite.java.cleanup.NoPrimitiveWrappersForToStringOrCompareTo
  - org.openrewrite.java.cleanup.NoRedundantJumpStatements
  - org.openrewrite.java.cleanup.NoToStringOnStringType
  - org.openrewrite.java.cleanup.NoValueOfOnStringType
  - org.openrewrite.java.cleanup.ObjectFinalizeCallsSuper
  - org.openrewrite.java.cleanup.PrimitiveWrapperClassConstructorToValueOf
  - org.openrewrite.java.cleanup.RedundantFileCreation
  - org.openrewrite.java.cleanup.RemoveExtraSemicolons
  - org.openrewrite.java.cleanup.RenameLocalVariablesToCamelCase
  - org.openrewrite.java.cleanup.RenameMethodsNamedHashcodeEqualOrTostring
  - org.openrewrite.java.cleanup.RenamePrivateFieldsToCamelCase
  - org.openrewrite.java.cleanup.ReplaceLambdaWithMethodReference
  - org.openrewrite.java.cleanup.ReplaceStringBuilderWithString
  - org.openrewrite.java.cleanup.SimplifyBooleanExpression
  - org.openrewrite.java.cleanup.SimplifyBooleanReturn
  - org.openrewrite.java.cleanup.StaticMethodNotFinal
  - org.openrewrite.java.cleanup.StringLiteralEquality
  - org.openrewrite.java.cleanup.UnnecessaryCloseInTryWithResources
  - org.openrewrite.java.cleanup.UnnecessaryExplicitTypeArguments
  - org.openrewrite.java.cleanup.UnnecessaryParentheses
  - org.openrewrite.java.cleanup.UnnecessaryPrimitiveAnnotations
  - org.openrewrite.java.cleanup.UpperCaseLiteralSuffixes
  - org.openrewrite.java.cleanup.UseDiamondOperator
  - org.openrewrite.java.cleanup.UseJavaStyleArrayDeclarations
  - org.openrewrite.java.cleanup.UseLambdaForFunctionalInterface
  - org.openrewrite.java.cleanup.WhileInsteadOfFor
  - org.openrewrite.java.cleanup.WriteOctalValuesAsDecimal
​
See how this recipe works across multiple open-source repositories
​​
​​
The Moderne public SaaS instance enables you to easily run recipes across thousands of open-source repositories.
Please contact Moderne for more information about safely running the recipes on your own codebase in a private SaaS.
Combine semantically equal catch blocks
Control flow statement indentation
Last modified 5d ago