Skip to main content

Zip slip

org.openrewrite.java.security.ZipSlip

Zip slip is an arbitrary file overwrite critical vulnerability, which typically results in remote command execution. A fuller description of this vulnerability is available in the Snyk documentation on it.

Tags​

  • CWE-22

Recipe source​

This recipe is only available to users of Moderne.

This recipe is available under the Moderne Proprietary License.

Example​

Before​
import java.io.File;
import java.io.FileOutputStream;
import java.io.RandomAccessFile;
import java.io.FileWriter;
import java.util.zip.ZipEntry;

public class ZipTest {
    public void m1(ZipEntry entry, File dir) throws Exception {
        String name = entry.getName();
        File file = new File(dir, name);
        FileOutputStream os = new FileOutputStream(file); // ZipSlip
        RandomAccessFile raf = new RandomAccessFile(file, "rw"); // ZipSlip
        FileWriter fw = new FileWriter(file); // ZipSlip
    }
}
After​
import java.io.*;
import java.util.zip.ZipEntry;

public class ZipTest {
    public void m1(ZipEntry entry, File dir) throws Exception {
        String name = entry.getName();
        File file = new File(dir, name);
        if (!file.toPath().normalize().startsWith(dir.toPath().normalize())) {
            throw new IOException("Bad zip entry");
        }
        FileOutputStream os = new FileOutputStream(file); // ZipSlip
        RandomAccessFile raf = new RandomAccessFile(file, "rw"); // ZipSlip
        FileWriter fw = new FileWriter(file); // ZipSlip
    }
}

Usage​

This recipe has no required configuration options. Users of Moderne can run it via the Moderne CLI:

You will need to have configured the Moderne CLI on your machine before you can run the following command.

shell
mod run . --recipe ZipSlip

If the recipe is not available locally, then you can install it using:

mod config recipes jar install org.openrewrite.recipe:rewrite-java-security:3.7.0

See how this recipe works across multiple open-source repositories​

Run this recipe on OSS repos at scale with the Moderne SaaS.

The community edition of the Moderne platform enables you to easily run recipes across thousands of open-source repositories.

Please contact Moderne for more information about safely running the recipes on your own codebase in a private SaaS.

Data Tables​

Source files that had results​

org.openrewrite.table.SourcesFileResults

Source files that were modified by the recipe run.

Column NameDescription
Source path before the runThe source path of the file before the run. null when a source file was created during the run.
Source path after the runA recipe may modify the source path. This is the path after the run. null when a source file was deleted during the run.
Parent of the recipe that made changesIn a hierarchical recipe, the parent of the recipe that made a change. Empty if this is the root of a hierarchy or if the recipe is not hierarchical at all.
Recipe that made changesThe specific recipe that made a change.
Estimated time savingAn estimated effort that a developer to fix manually instead of using this recipe, in unit of seconds.
CycleThe recipe cycle in which the change was made.

Contributors​

Jonathan Leitschuh, Jonathan Schnéider, Knut Wannheden, Tim te Beek, Simon Verhoeven